Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the latest greatest Python deps #1618

Merged
merged 3 commits into from
Jul 9, 2024
Merged

Use the latest greatest Python deps #1618

merged 3 commits into from
Jul 9, 2024

Conversation

evetion
Copy link
Member

@evetion evetion commented Jul 9, 2024

Fixes #1573

This only fixes us to the first version of pandera that supports numpy 2, the rest should follow automatically.

I took longer than I want to admit to find that the previous [None, 1] is now silently coerced to [0,1] and therefore passed validation, and failed the test.

I also (still?) see

tests/test_model.py::test_xugrid[model0]
  <frozen importlib._bootstrap>:488: RuntimeWarning: numpy.ndarray size changed, may indicate binary incompatibility. Expected 16 from C header, got 96 from PyObject

Which is probably due to xugrid/netcdf/meshkernel(?) using something compiled against a different numpy version.

@evetion evetion requested a review from visr July 9, 2024 09:05
@visr
Copy link
Member

visr commented Jul 9, 2024

I looked into the pyarrow situation from #1542, and filed prefix-dev/pixi#1594.

In short, nothing is broken on pyarrow 16, it is just that the update from pyarrow 15 to 16 breaks the 16 installation. So let's update, but we may need to delete our .pixi folder.

Copy link
Member

@visr visr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I upgraded pyarrow and updated pyproject.toml.
In trying this out I also discovered that we need to unset juliaup overrides if they are already set, so I changed that and filed JuliaLang/juliaup#987.

@evetion
Copy link
Member Author

evetion commented Jul 9, 2024

I looked into the pyarrow situation from #1542, and filed prefix-dev/pixi#1594.

In short, nothing is broken on pyarrow 16, it is just that the update from pyarrow 15 to 16 breaks the 16 installation. So let's update, but we may need to delete our .pixi folder.

Your error seemed different from mine, but cool that you found a possible source for the __version__ error. 👍🏻

@visr
Copy link
Member

visr commented Jul 9, 2024

I got the same error as #1542, until I realized I didn't need pandas to reproduce.

@visr visr merged commit 08c6856 into main Jul 9, 2024
25 checks passed
@visr visr deleted the feat/upgrade-py-dep branch July 9, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support latest breaking dependency versions
2 participants